From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
Subject: | RE: logical_replication_mode |
Date: | 2023-08-25 06:52:14 |
Message-ID: | OS0PR01MB5716F62F6A598125D2004D3C94E3A@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Friday, August 25, 2023 12:28 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Aug 24, 2023 at 12:45 PM Peter Eisentraut <peter(at)eisentraut(dot)org>
> wrote:
> >
> > I suggest we rename this setting to something starting with debug_.
> > Right now, the name looks much too tempting for users to fiddle with.
> > I think this is similar to force_parallel_mode.
> >
>
> +1. How about debug_logical_replication?
>
> > Also, the descriptions in guc_tables.c could be improved. For
> > example,
> >
> > gettext_noop("Controls when to replicate or apply each change."),
> >
> > is pretty content-free and unhelpful.
> >
>
> The other possibility I could think of is to change short_desc as:
> "Allows to replicate each change for large transactions.". Do you have any
> better ideas?
How about "Forces immediate streaming or serialization of changes in large
transactions." which is similar to the description in document.
I agree that renaming it to debug_xx would be better and
here is a patch that tries to do this.
Best Regards,
Hou zj
Attachment | Content-Type | Size |
---|---|---|
0001-Rename-logical_replication_mode-to-debug_logical_rep.patch | application/octet-stream | 12.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-08-25 07:00:24 | Re: initdb caching during tests |
Previous Message | Matthias van de Meent | 2023-08-25 06:22:24 | Re: broken master regress tests |