From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Skip partition tuple routing with constant partition key |
Date: | 2021-05-24 08:17:34 |
Message-ID: | OS0PR01MB5716F30A47440254F8E5507194269@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
From: houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com>
Sent: Monday, May 24, 2021 3:58 PM
>
> From: Tsunakawa, Takayuki <mailto:tsunakawa(dot)takay(at)fujitsu(dot)com>
> Sent: Monday, May 24, 2021 3:34 PM
> >
> > From: mailto:houzj(dot)fnst(at)fujitsu(dot)com <mailto:houzj(dot)fnst(at)fujitsu(dot)com>
> > > I think this patch can solve the performance degradation of key
> > > expression after applying the [Save the last partition] patch.
> > > Besides, this could be a separate patch which can improve some more
> cases.
> > > Thoughts ?
> >
> > Thank you for proposing an impressive improvement so quickly! Yes,
> > I'm in the mood for adopting Amit-san's patch as a base because it's
> > compact and readable, and plus add this patch of yours to complement
> > the partition key function case.
>
> Thanks for looking into this.
>
> > But ...
> >
> > * Applying your patch alone produced a compilation error. I'm sorry I
> > mistakenly deleted the compile log, but it said something like
> > "There's a redeclaration of PartKeyContext in partcache.h; the
> > original definition is in partdef.h"
>
> It seems a little strange, I have compiled it alone in two different linux machine
> and did not find such an error. Did you compile it on a windows machine ?
Ah, Maybe I found the issue.
Attaching a new patch, please have a try on this patch.
Best regards,
houzj
Attachment | Content-Type | Size |
---|---|---|
0001-improving-ExecPartitionCheck.patch | application/octet-stream | 25.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2021-05-24 08:27:02 | Re: Skip partition tuple routing with constant partition key |
Previous Message | tsunakawa.takay@fujitsu.com | 2021-05-24 08:17:29 | RE: Skip partition tuple routing with constant partition key |