| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | RE: logical replication empty transactions |
| Date: | 2022-03-28 12:21:42 |
| Message-ID: | OS0PR01MB5716946347F607F4CFB02FCE941D9@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, March 28, 2022 3:08 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Mar 25, 2022 at 12:50 PM houzj(dot)fnst(at)fujitsu(dot)com
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > Attach the new version patch with this change.
> >
>
> Few comments:
Thanks for the comments.
> =================
> 1. I think we can move the keep_alive check after the tracklag record
> check to keep it consistent with another patch [1].
Changed.
> 2. Add the comment about the new parameter skipped_xact atop
> WalSndUpdateProgress.
Added.
> 3. I think we need to call pq_flush_if_writable after sending a
> keepalive message to avoid delaying sync transactions.
Agreed.
If we don’t flush the data, we might flush the keepalive later than before. And
we could get the reply later as well and then the release of syncwait could be
delayed.
Attach the new version patch which addressed the above comments.
The patch also adds a loop after the newly added keepalive message
to make sure the message is actually flushed to the client like what
did in WalSndWriteData.
Best regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v32-0001-Skip-empty-transactions-for-logical-replication.patch | application/octet-stream | 21.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-03-28 12:36:15 | Re: Add LZ4 compression in pg_dump |
| Previous Message | Andrew Dunstan | 2022-03-28 11:04:05 | Re: SQL/JSON: functions |