From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | RE: wake up logical workers after ALTER SUBSCRIPTION |
Date: | 2023-01-24 02:55:07 |
Message-ID: | OS0PR01MB5716860B1454C34E5B179B6694C99@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Monday, January 23, 2023 3:13 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
Hi,
>
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> > On Tue, Jan 10, 2023 at 10:59:14AM +0530, Amit Kapila wrote:
> >> I haven't looked in detail but isn't it better to explain somewhere
> >> in the comments that it achieves to rate limit the restart of workers
> >> in case of error and allows them to restart immediately in case of
> >> subscription parameter change?
>
> > I expanded one of the existing comments to make this clear.
>
> I pushed v17 with some mostly-cosmetic changes, including more comments.
I noticed one minor thing in this commit.
-
LogicalRepCtx->last_start_dsh = DSM_HANDLE_INVALID;
-
The code takes the last_start_dsh as dsm_handle, but it seems it is a dsa_pointer.
" typedef dsa_pointer dshash_table_handle;" This won’t cause any problem, but I feel
It would be easier to understand if we take it as dsa_pointer and use InvalidDsaPointer here,
like what he attached patch does. What do you think ?
Best regards,
Hou zj
Attachment | Content-Type | Size |
---|---|---|
0001-Take-last_start_dsh-as-dsa_pointer.patch | application/octet-stream | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2023-01-24 02:56:36 | Re: Decoupling antiwraparound autovacuum from special rules around auto cancellation |
Previous Message | Kyotaro Horiguchi | 2023-01-24 02:45:35 | Re: Time delayed LR (WAS Re: logical replication restrictions) |