| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: Column Filtering in Logical Replication |
| Date: | 2022-03-14 11:12:25 |
| Message-ID: | OS0PR01MB57164514E1DE1E579B0B6C46940F9@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, March 14, 2022 5:08 AM Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>
> On 3/12/22 05:30, Amit Kapila wrote:
> >> ...
> >
> > Okay, please find attached. I have done basic testing of this, if we
> > agree with this approach then this will require some more testing.
> >
>
> Thanks, the proposed changes seem like a clear improvement, so I've
> added them, with some minor tweaks (mostly to comments).
Hi,
Thanks for updating the patches !
And sorry for the row filter bug caused by my mistake.
I looked at the two fixup patches. I am thinking would it be better if we
add one testcase for these two bugs? Maybe like the attachment.
(Attach the fixup patch to make the cfbot happy)
Best regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| 0003-fixup-row-filter-publications-20220313.patch | application/octet-stream | 2.1 KB |
| 0001-fixup-publish_as_relid-20220313.patch | application/octet-stream | 6.4 KB |
| 0002-testcase-for-publish-as-relid.patch | application/octet-stream | 3.4 KB |
| 0004-testcase-for-row-filter-publication.patch | application/octet-stream | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-03-14 11:33:59 | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |
| Previous Message | Amit Kapila | 2022-03-14 10:49:00 | Re: Optionally automatically disable logical replication subscriptions on error |