From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Perform streaming logical transactions by background workers and parallel apply |
Date: | 2022-12-20 10:16:23 |
Message-ID: | OS0PR01MB57163693482C5470C41914AF94EA9@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tuesday, December 20, 2022 5:12 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Dec 19, 2022 at 6:17 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Sat, Dec 17, 2022 at 7:34 PM houzj(dot)fnst(at)fujitsu(dot)com
> > <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > >
> > > Agreed. I have addressed all the comments and did some cosmetic changes.
> > > Attach the new version patch set.
> > >
> >
> > Few comments:
> > ============
> >
>
> Few more minor points:
> 1.
> -static inline void
> +void
> changes_filename(char *path, Oid subid, TransactionId xid) {
>
> This function seems to be used only in worker.c. So, what is the need to make it
> extern?
Oh, I forgot to revert this change after removing the one caller outside of worker.c.
Changed.
>
> 2. I have made a few changes in the comments. See attached. This is atop my
> yesterday's top-up patch.
Thanks, I have checked and merged this.
> I think we should merge the 0001 and 0002 patches as they need to be
> committed together.
Merged and ran the pgident for the patch set.
Attach the new version patch set which addressed all comments so far.
Best regards,
Hou zj
Attachment | Content-Type | Size |
---|---|---|
v63-0001-Perform-streaming-logical-transactions-by-parall.patch | application/octet-stream | 214.4 KB |
v63-0002-Test-streaming-parallel-option-in-tap-test.patch | application/octet-stream | 80.1 KB |
v63-0003-Allow-streaming-every-change-without-waiting-til.patch | application/octet-stream | 9.4 KB |
v63-0004-Add-GUC-stream_serialize_threshold-and-test-seri.patch | application/octet-stream | 12.5 KB |
v63-0005-Stop-extra-worker-if-GUC-was-changed.patch | application/octet-stream | 4.6 KB |
v63-0006-Retry-to-apply-streaming-xact-only-in-apply-work.patch | application/octet-stream | 22.6 KB |
v63-0007-Add-a-main_worker_pid-to-pg_stat_subscription.patch | application/octet-stream | 8.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2022-12-20 10:19:51 | Re: Allow batched insert during cross-partition updates |
Previous Message | houzj.fnst@fujitsu.com | 2022-12-20 10:14:49 | RE: Perform streaming logical transactions by background workers and parallel apply |