From: | Yulin PEI <ypeiae(at)connect(dot)ust(dot)hk> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | 回复: 回复: [PATCH] BUG FIX: Core dump could happen when VACUUM FULL in standalone mode |
Date: | 2020-12-01 01:54:50 |
Message-ID: | HK0PR01MB2274472F0850D8596E2A784BF4F40@HK0PR01MB2274.apcprd01.prod.exchangelabs.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I think you are right after reading code in compute_parallel_vacuum_workers() :)
________________________________
发件人: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
发送时间: 2020年12月1日 2:54
收件人: Yulin PEI <ypeiae(at)connect(dot)ust(dot)hk>
抄送: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>; pgsql-hackers(at)lists(dot)postgresql(dot)org <pgsql-hackers(at)lists(dot)postgresql(dot)org>
主题: Re: 回复: [PATCH] BUG FIX: Core dump could happen when VACUUM FULL in standalone mode
Yulin PEI <ypeiae(at)connect(dot)ust(dot)hk> writes:
> Yes, I agree because (IsNormalProcessingMode() ) means that current process is not in bootstrap mode and postmaster process will not build index.
> So my new modified patch is attached.
This is a good catch, but the proposed fix still seems pretty random
and unlike how it's done elsewhere. It seems to me that since
index_build() is relying on plan_create_index_workers() to assess
parallel safety, that's where to check IsUnderPostmaster. Moreover,
the existing code in compute_parallel_vacuum_workers (which gets
this right) associates the IsUnderPostmaster check with the initial
check on max_parallel_maintenance_workers. So I think that the
right fix is to adopt the compute_parallel_vacuum_workers coding
in plan_create_index_workers, and thereby create a model for future
uses of max_parallel_maintenance_workers to follow.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | James Coleman | 2020-12-01 01:59:17 | Re: Fix generate_useful_gather_paths for parallel unsafe pathkeys |
Previous Message | Masahiko Sawada | 2020-12-01 01:45:07 | Re: VACUUM (DISABLE_PAGE_SKIPPING on) |