| From: | "Nagaura, Ryohei" <nagaura(dot)ryohei(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, 'Michael Paquier' <michael(at)paquier(dot)xyz>, "AYahorau(at)ibagroup(dot)eu" <AYahorau(at)ibagroup(dot)eu>, "'Fabien COELHO'" <coelho(at)cri(dot)ensmp(dot)fr>, "'pgsql-hackers(at)postgresql(dot)org'" <pgsql-hackers(at)postgresql(dot)org>, "MikalaiKeida(at)ibagroup(dot)eu" <MikalaiKeida(at)ibagroup(dot)eu> |
| Subject: | RE: Timeout parameters |
| Date: | 2019-02-27 04:25:27 |
| Message-ID: | EDA4195584F5064680D8130B1CA91C453EC3CC@G01JPEXMBYT04 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, kirk-san.
Thank you for review.
> From: Jamison, Kirk <k(dot)jamison(at)jp(dot)fujitsu(dot)com>
> Your socket_timeout patch still does not apply either with git or patch command. It
> says it's still corrupted.
> I'm not sure about the workaround, because the --ignore-space-change and
> --ignore-whitespace did not work for me.
> Maybe it might have something to do with your editor when creating the patch.
> Could you confirm?
> The CFbot is also another way to check if your latest patches work.
> http://commitfest.cputube.org/
It may be caused by git diff command with no option.
The new patches are created by git diff -w.
About socket_timeout:
Your feedback looks good so that I adopted it. Please confirm it.
About TCP_USER_TIMEOUT:
There is no change in sources.
Just change the command option "git diff" -> "git diff -w".
Best regards,
---------------------
Ryohei Nagaura
| Attachment | Content-Type | Size |
|---|---|---|
| TCP_backend_v7.patch | application/octet-stream | 6.0 KB |
| TCP_interface_v7.patch | application/octet-stream | 4.8 KB |
| socket_timeout_v7.patch | application/octet-stream | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-02-27 04:45:56 | Re: Early WIP/PoC for inlining CTEs |
| Previous Message | Amit Kapila | 2019-02-27 04:05:49 | Re: pgsql: Avoid creation of the free space map for small heap relations, t |