From: | Justin Kwan <justinpkwan(at)outlook(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh <vignesh(at)cloudflare(dot)com>, vignesh ravichandran <admin(at)viggy28(dot)dev>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "jkwan(at)cloudflare(dot)com" <jkwan(at)cloudflare(dot)com> |
Subject: | Re: Making pg_rewind faster |
Date: | 2022-07-28 22:46:28 |
Message-ID: | DM6PR03MB45706B96C93EEE51E920BBEBA0969@DM6PR03MB4570.namprd03.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Michael,
Not sure if this email went through previously but thank you for your feedback, I've incorporated your suggestions by scanning the logs produced from pg_rewind when asserting that certain WAL segment files were skipped from being copied over to the target server.
I've also updated the pg_rewind patch file to target the Postgres master branch (version 16 to be). Please see attached.
Thanks,
Justin
________________________________
From: Justin Kwan <justinpkwan(at)outlook(dot)com>
Sent: July 18, 2022 1:14 PM
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>; vignesh <vignesh(at)cloudflare(dot)com>; jkwan(at)cloudflare(dot)com <jkwan(at)cloudflare(dot)com>; vignesh ravichandran <admin(at)viggy28(dot)dev>; hlinnaka(at)iki(dot)fi <hlinnaka(at)iki(dot)fi>
Subject: Re: Making pg_rewind faster
Hi Tom,
Thank you for taking a look at this and that sounds good. I will send over a patch compatible with Postgres v16.
Justin
________________________________
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Sent: July 17, 2022 2:40 PM
To: Justin Kwan <justinpkwan(at)outlook(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>; vignesh <vignesh(at)cloudflare(dot)com>; jkwan(at)cloudflare(dot)com <jkwan(at)cloudflare(dot)com>; vignesh ravichandran <admin(at)viggy28(dot)dev>; hlinnaka(at)iki(dot)fi <hlinnaka(at)iki(dot)fi>
Subject: Re: Making pg_rewind faster
Justin Kwan <justinpkwan(at)outlook(dot)com> writes:
> I've also attached the pg_rewind optimization patch file for Postgres version 14.4. The previous patch file targets version Postgres version 15 Beta 1/2.
It's very unlikely that we would consider committing such changes into
released branches. In fact, it's too late even for v15. You should
be submitting non-bug-fix patches against master (v16-to-be).
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
v2-pg16-0001-Avoid-copying-WAL-segments-before-divergence-to-spee.patch | application/octet-stream | 10.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2022-07-28 22:57:52 | Re: Cygwin cleanup |
Previous Message | Nathan Bossart | 2022-07-28 22:46:18 | Re: [Patch] Fix bounds check in trim_array() |