From: | Imai Yoshikazu <yoshikazu_i443(at)live(dot)jp> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Cc: | Yoshikazu Imai <imai(dot)yoshikazu(at)fujitsu(dot)com> |
Subject: | Re: [Proposal] Add accumulated statistics for wait event |
Date: | 2020-01-15 13:15:47 |
Message-ID: | CO2PR07MB2549B39C4332F2BFB1E4B10CBC370@CO2PR07MB2549.namprd07.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020/01/13 4:11, Pavel Stehule wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: tested, passed
>
> I like this patch, because I used similar functionality some years ago very successfully. The implementation is almost simple, and the result should be valid by used method.
Thanks for your review!
> The potential problem is performance impact. Very early test show impact cca 3% worst case, but I'll try to repeat these tests.
Yes, performance impact is the main concern. I want to know how it
affects performance in various test cases or on various environments.
> There are some ending whitespaces and useless tabs.
>
> The new status of this patch is: Waiting on Author
I attach v4 patches removing those extra whitespaces of the end of lines
and useless tabs.
--
Yoshikazu Imai
Attachment | Content-Type | Size |
---|---|---|
0001-Add-pg_stat_waitaccum-view-v4.patch | text/plain | 30.6 KB |
0002-POC-Change-measuring-method-of-wait-event-time-fr-v4.patch | text/plain | 1.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Floris Van Nee | 2020-01-15 13:33:41 | RE: Index Skip Scan |
Previous Message | 曾文旌 (义从) | 2020-01-15 13:10:25 | Re: [Proposal] Global temporary tables |