Re: [HACKERS] pg_upgrade to clusters with a different WAL segment size

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeremy Schneider <schneider(at)ardentperf(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] pg_upgrade to clusters with a different WAL segment size
Date: 2018-03-14 00:53:08
Message-ID: CE058CA0-8C37-4F9C-8C33-27DAF3931E40@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is a new set of patches that addresses most of Peter's feedback.
I've split it into four pieces:

0001: Fix division-by-zero error in pg_controldata
0002: Fix division-by-zero error in pg_resetwal
0003: Allow users to specify WAL segment size in pg_resetwal
0004: Add long options to pg_resetwal (including --wal-segsize)

On 3/3/18, 12:22 PM, "Peter Eisentraut" <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> The patch "Configurable file mode mask" contains the beginning of a test
> suite for pg_resetwal. It would be great if we could get a test case
> for this new functionality implemented.

I haven't added a test case yet, as this thread [0] seems to still be
in-progress.

Nathan

[0] https://postgr.es/m/ad346fe6-b23e-59f1-ecb7-0e08390ad629%40pgmasters.net

Attachment Content-Type Size
v2-0001-Prevent-division-by-zero-errors-in-pg_controldata.patch application/octet-stream 1.6 KB
v2-0002-Prevent-division-by-zero-errors-in-pg_resetwal.patch application/octet-stream 3.1 KB
v2-0003-Allow-users-to-change-the-WAL-segment-size-with-p.patch application/octet-stream 4.6 KB
v2-0004-Add-long-options-to-pg_resetwal.patch application/octet-stream 8.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Gould 2018-03-14 01:10:14 Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuples inaccurate.
Previous Message David G. Johnston 2018-03-14 00:39:37 Re: Fixes for missing schema qualifications