Re: collect_corrupt_items_vacuum.patch

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: collect_corrupt_items_vacuum.patch
Date: 2024-03-12 12:10:59
Message-ID: CAPpHfdvN1wsFsPkA8O_DuY3=cOWw0F9nBPi4biyC1+juYQpqdw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 14, 2024 at 4:35 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> On Sat, Jan 13, 2024 at 7:33 PM Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> wrote:
> > Thank you, there is one small point left (in the comment): can you
> > replace "guarantteed to be to be newer" to "guaranteed to be newer",
> > file src/backend/storage/ipc/procarray.c?
>
> Fixed. Thank you for catching this.

I made the following improvements to the patch.
1. I find a way to implement the path with less changes to the core
code. The GetRunningTransactionData() function allows to get the
least running xid, all I need is to add database-aware values.
2. I added the TAP test reproducing the original issue.

I'm going to push this if no objections.

------
Regards,
Alexander Korotkov

Attachment Content-Type Size
v6-0001-Fix-false-reports-in-pg_visibility.patch application/octet-stream 10.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2024-03-12 12:20:10 Re: Detoasting optionally to make Explain-Analyze less misleading
Previous Message Amit Langote 2024-03-12 12:07:01 Re: remaining sql/json patches