From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
---|---|
To: | vignesh C <vignesh21(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, David Steele <david(at)pgmasters(dot)net> |
Subject: | Re: Psql patch to show access methods info |
Date: | 2020-03-06 00:57:57 |
Message-ID: | CAPpHfdvF+=L9edfdkpScT=1VJv=0CFAHPNUioThhKi70qBLHyQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 5, 2020 at 8:34 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> On Wed, Mar 4, 2020 at 5:02 AM Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> >
> > Hi!
> >
> > Thank you for the review. Revised patch is attached.
> >
>
> Thanks for working on comments and providing a new patch.
> One small observation I noticed:
> postgres=# \dAc brin oid
> Index access method operator classes
> AM | Input type | Storage type | Operator class | Default?
> ------+------------+--------------+----------------+----------
> brin | oid | | oid_minmax_ops | yes
> (1 row)
>
> postgres=# \dAcx brin oid
> Index access method operator classes
> AM | Input type | Storage type | Operator class | Default?
> ------+------------+--------------+----------------+----------
> brin | oid | | oid_minmax_ops | yes
> (1 row)
>
> Output of \dAc and \dAcx seems to be same. Is this expected?
It might seem strange, but majority of psql commands allows arbitrary
suffixes and ignore them. For instance:
postgres=# \dt
Did not find any relations.
postgres=# \dtttttt
Did not find any relations.
I think if we want to fix this, we should do it in a separate path,
which would fix at the psql commands.
BTW, new revision of the patch is attached. It contains cosmetic
changes to the documentation, comments etc.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment | Content-Type | Size |
---|---|---|
0001-Add-psql-AM-info-commands-v13.patch | application/octet-stream | 28.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-03-06 01:21:20 | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
Previous Message | Andres Freund | 2020-03-06 00:39:42 | Re: Proposal: PqSendBuffer removal |