| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] kNN for SP-GiST |
| Date: | 2018-09-16 21:03:45 |
| Message-ID: | CAPpHfdtLbjKiPLgPHM25HGMs096bvmJDmT5E_s38f_2EQTfjpA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 30, 2018 at 3:57 PM Alexander Korotkov <
a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> Generally patch looks close to committable shape for me. I'm going to
> revise code and documentation again, split it up, and then propose to
> commit.
>
I've revised this patch again. This revision includes a lot of code
beautification, adjustments to comments and documentation. Also, after
reviewing bug fix [1] I found that we don't need separate memory context
for queue. traversalCxt looks perfectly fine for that purpose, because
there it's single scan lifetime. Also, it appears to me that it's OK to be
a single patch: besides KNN SP-GiST and opclasses it contains only
extraction of few common function between GiST and SP-GiST.
So, I'm going to commit this if no objections.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| knn-spgist-v9.patch | application/octet-stream | 100.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-09-16 21:57:05 | Re: XMLNAMESPACES (was Re: Clarification of nodeToString() use cases) |
| Previous Message | Stephen Frost | 2018-09-16 21:02:15 | Re: Collation versioning |