From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
---|---|
To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
Cc: | Jim Nasby <jim(dot)nasby(at)openscg(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com> |
Subject: | Re: PinBuffer() no longer makes use of strategy |
Date: | 2017-03-20 15:12:04 |
Message-ID: | CAPpHfdsckXE51mEM_n3x4Sd1b5+Y_QisrRZRzcxD+-2LAAYgPg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 20, 2017 at 6:09 PM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
> if (buf->usage_count < BM_MAX_USAGE_COUNT)
>> if (BUF_STATE_GET_USAGECOUNT(buf_state) != BM_MAX_USAGE_COUNT)
>>
>> being prone to paranoia, I prefer the first, but I've seen both
>> styles in
>> the code so I don't know if it's worth futzing with.
>>
>>
>> Ok, let's be paranoic and do this same way as before. Revised patch is
>> attached.
>>
>
> I see the change was done in 9.6 release cycle in commit
> 48354581a49c30f5757c203415aa8412d85b0f70 at April, 10. Does it mean the
> fix should be backpatched too?
I think so. This patch reverts unintentional change and can be considered
as bug fix.
BTW, sorry for unicode filename in previous letter.
Patch with normal ASCII name is attached.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment | Content-Type | Size |
---|---|---|
put-buffer-usagecount-logic-back-2.patch | application/octet-stream | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2017-03-20 15:14:38 | Re: Our feature change policy |
Previous Message | Pavan Deolasee | 2017-03-20 15:09:43 | Re: Patch: Write Amplification Reduction Method (WARM) |