From: | Filip Rembiałkowski <filip(dot)rembialkowski(at)gmail(dot)com> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Catalin Iacob <iacobcatalin(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net> |
Subject: | Re: Re: proposal: make NOTIFY list de-duplication optional |
Date: | 2019-03-10 10:53:15 |
Message-ID: | CAP_rwwnt2ABdoqXTTLbmJDOSk617+6wN=mqjFiT=b5KmuY64wg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thank you.
Here is my latest attempt, with actual syntax error handling.
Also, the syntax is updated to what Tom Lane suggested in other
thread (with another variant of the same thing, from Julien Demoor)
NOTIFY [ ( option [, ...] ) ] channel [ , payload ]
Still no hash table fallback is implemented, so this is *not* a
performance improvement. Only a little more flexibility.
On Sat, Mar 9, 2019 at 3:31 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Fri, Mar 8, 2019 at 1:37 PM Filip Rembiałkowski
> <filip(dot)rembialkowski(at)gmail(dot)com> wrote:
> > See attached patch... I'm ready to work on so it can get merged in the next CF.
>
> Hi Filip,
>
> Seen on Travis:
>
> async ... FAILED 126 ms
>
> Looks like the new error isn't being raised for invalid send mode?
> (What kind of error message is "?" anyway? :-))
>
> ERROR: channel name too long
> -- Should fail. Invalid 3rd parameter
> NOTIFY notify_async2, 'test', 'invalid';
> -ERROR: ?
> NOTIFY notify_async2, 'test', true;
> -ERROR: ?
> --Should work. Valid NOTIFY/LISTEN/UNLISTEN commands
> NOTIFY notify_async2;
> NOTIFY notify_async2, '';
>
> --
> Thomas Munro
> https://enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
postgres-notify-options-20190310_01.patch | text/x-patch | 23.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2019-03-10 11:08:45 | Re: Performance issue in foreign-key-aware join estimation |
Previous Message | Alexander Korotkov | 2019-03-10 10:51:45 | Re: jsonpath |