From: | David Christensen <david(dot)christensen(at)crunchydata(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |
Date: | 2022-12-23 19:28:27 |
Message-ID: | CAOxo6XJyYZdiEsF5r3+h1BSPprQ6+8=a4EgNiePWQjyFaafdZw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 23, 2022 at 12:57 PM David Christensen
<david(dot)christensen(at)crunchydata(dot)com> wrote:
>
> On Wed, Dec 21, 2022 at 5:47 AM Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
[snip]
> > 2. +$node->init(extra => ['-k'], allows_streaming => 1);
> > When enabled with allows_streaming, there are a bunch of things that
> > happen to the node while initializing, I don't think we need all of
> > them for this.
>
> I think the "allows_streaming" was required to ensure the WAL files
> were preserved properly, and was the approach we ended up taking
> rather than trying to fail the archive_command or other approaches I'd
> taken earlier. I'd rather keep this if we can, unless you can propose
> a different approach that would continue to work in the same way.
Confirmed that we needed this in order to create the replication slot,
so this /is/ required for the test to work.
Enclosing v11 with yours and Michael's latest feedback.
Best,
David
Attachment | Content-Type | Size |
---|---|---|
v11-0001-Teach-pg_waldump-to-extract-FPIs-from-the-WAL-st.patch | application/octet-stream | 13.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dag Lem | 2022-12-23 20:34:09 | Re: daitch_mokotoff module |
Previous Message | David Christensen | 2022-12-23 18:58:45 | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |