From: | Tatsuro Yamada <yamatattsu(at)gmail(dot)com> |
---|---|
To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
Cc: | Tatsuro Yamada <tatsuro(dot)yamada(at)ntt(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Showing applied extended statistics in explain Part 2 |
Date: | 2024-06-28 11:16:03 |
Message-ID: | CAOKkKFv49qmE39eRWuQQ94xbtGv_K0aaUZe3VDi0ZzPoRiGc1g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Tomas and All,
Attached file is a new patch including:
6) Add stats option to explain command
7) The patch really needs some docs (partly)
>4) Add new node (resolve errors in cfbot and prepared statement)
I tried adding a new node in pathnode.h, but it doesn't work well.
So, it needs more time to implement it successfully because this is
the first time to add a new node in it.
> 8) Add regression test (stats_ext.sql)
Actually, I am not yet able to add new test cases to stats_ext.sql.
Instead, I created a simple test (test.sql) and have attached it.
Also, output.txt is the test result.
To add new test cases to stats_ext.sql,
I'd like to decide on a strategy for modifying it. In particular, there are
381 places where the check_estimated_rows function is used, so should I
include the same number of tests, or should we include the bare minimum
of tests that cover the code path? I think only the latter would be fine.
Any advice is appreciated. :-D
P.S.
I'm going to investigate how to use CI this weekend hopefully.
Regards,
Tatsuro Yamada
Attachment | Content-Type | Size |
---|---|---|
output.txt | text/plain | 3.9 KB |
0001-Add-a-new-option-STATS-to-Explain-command.patch | application/x-patch | 20.8 KB |
test.sql | application/octet-stream | 2.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2024-06-28 11:53:31 | Re: pgsql: Add more SQL/JSON constructor functions |
Previous Message | Amit Kapila | 2024-06-28 11:07:05 | Re: pg_createsubscriber: drop pre-existing subscriptions from the converted node |