From: | Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com> |
---|---|
To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Passing query string to workers |
Date: | 2017-02-16 12:17:57 |
Message-ID: | CAOGQiiNBFtxXTsE+Qcri4sUedkenHGgiGTrVRLzeYMO5oS5nLg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Feb 16, 2017 at 5:06 PM, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
wrote:
>
> >>
> >> Another question is don't we need to set debug_query_string in worker?
> >
> > In the updated version I am setting it in ParallelQueryMain.
> >
> Ahh, I missed that. debug_query_string is used to show the log
> statements. Hence, it should be set.
>
> + queryString = shm_toc_lookup(toc, PARALLEL_KEY_QUERY_TEXT);
> + debug_query_string = shm_toc_lookup(toc, PARALLEL_KEY_QUERY_TEXT);
> + pgstat_report_activity(STATE_RUNNING, shm_toc_lookup(toc,
> PARALLEL_KEY_QUERY_TEXT));
> Just one lookup is sufficient.
>
> Fixed.
Other that that I updated some comments and other cleanup things. Please
find the attached patch for the revised version.
--
Regards,
Rafia Sabih
EnterpriseDB: http://www.enterprisedb.com/
Attachment | Content-Type | Size |
---|---|---|
pass_queryText_to_workers_v5.patch | application/octet-stream | 4.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-02-16 12:41:37 | Re: [PROPOSAL] Temporal query processing with range types |
Previous Message | Kyotaro HORIGUCHI | 2017-02-16 12:06:00 | Re: asynchronous execution |