From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx |
Date: | 2024-01-17 09:05:33 |
Message-ID: | CAO6_XqoxjRngBxnQdT0HL6HJrva5jpKeRvs3H6T8XGoTh2PDVw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> I do realize the same is true for plain \bind, but it seems
> like a bug there too.
The unscanned bind's parameters are discarded later in the
HandleSlashCmds functions. So adding the ignore_slash_options() for
inactive branches scans and discards them earlier. I will add it to
match what's done in the other commands but I don't think it's
testable as the behaviour is the same unless I miss something.
I did add the \bind, \bindx, \close and \parse to the inactive branch
tests to complete the list.
> One more usability thing. I think \parse and \close should not require
> a \g to send the message. You can do that by returning PSQL_CMD_SEND
> instead of PSQL_CMD_SKIP_LIN
Changed.
> I think the examples for \bindx and \close
> should use \parse instead of PREPARE
Done. I had to rely on manual PREPARE for my first tests and it leaked
in the docs.
Attachment | Content-Type | Size |
---|---|---|
v3-0001-psql-Add-support-for-prepared-stmt-with-extended-.patch | application/octet-stream | 19.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Laurenz Albe | 2024-01-17 09:30:43 | Re: psql JSON output format |
Previous Message | Jeevan Chalke | 2024-01-17 09:03:36 | Re: More new SQL/JSON item methods |