From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | [pgAdmin4][Patch]: RM #3232 Backup with incorrect path stays in broken state |
Date: | 2018-10-19 13:30:29 |
Message-ID: | CANxoLDfA_ycCJaDrTve+5jDS3nc_Y9R+mXG_gQ1yPWqGFOxkyA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
I have fixed RM #3232 Backup with incorrect path stays in broken state.
Attached patch file contains following:
- Fix for RM #3232, in case user provide wrong path then
"Backup/Restore/Maintenance/ImportExport" utility won't start and user
will get an pop up for file not found.
- Correct the logic for "Backup/Restore/Maintenance/ImportExport" test
cases, it is failing when default binary path is not set in the test_
config.json file. It should be skipped if path not provided.
- Skip all the test cases for "Backup/Restore/Maintenance/ImportExport"
if respective utility files are not found on the given path.
- Added "Stop Process" button to stop the
Utility("Backup/Restore/Maintenance/ImportExport") process. To support
this I used "*psutil*" python package to terminate the process. psutil
is a cross platform package.
- Modify Jasmin test cases.
I have tested the patch on OSX, Linux and Windows. Please review it.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachment | Content-Type | Size |
---|---|---|
RM_3232.patch | application/octet-stream | 54.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | aman gupta | 2018-10-22 05:56:44 | Optimizing Postgresql ILIKE while query |
Previous Message | Akshay Joshi | 2018-10-18 12:33:57 | pgAdmin 4 commit: Fixed issue where session files are not deleted first |