From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
Subject: | Re: Pgoutput not capturing the generated columns |
Date: | 2024-07-19 06:01:01 |
Message-ID: | CANhcyEUzUurrX38HGvG30gV92YDz6WmnnwNRYMVY4tiga-8KZg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, 18 Jul 2024 at 13:55, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi, here are some review comments for v19-0002
> ======
> src/test/subscription/t/004_sync.pl
>
> 1.
> This new test is not related to generated columns. IIRC, this is just
> some test that we discovered missing during review of this thread. As
> such, I think this change can be posted/patched separately from this
> thread.
>
I have removed the test for this thread.
I have also addressed the remaining comments for v19-0002 patch.
Please find the latest patches.
v20-0001 - not modified
v20-0002 - Addressed the comments
v20-0003 - Addressed the comments
v20-0004 - Not modified
Thanks and Regards,
Shlok Kyal
Attachment | Content-Type | Size |
---|---|---|
v20-0001-Enable-support-for-include_generated_columns-opt.patch | application/octet-stream | 89.6 KB |
v20-0002-Support-replication-of-generated-column-during-i.patch | application/octet-stream | 25.9 KB |
v20-0003-Fix-behaviour-for-Virtual-Generated-columns.patch | application/octet-stream | 15.7 KB |
v20-0004-Improve-include-generated-column-option-handling.patch | application/octet-stream | 15.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Shlok Kyal | 2024-07-19 06:03:51 | Re: Pgoutput not capturing the generated columns |
Previous Message | jian he | 2024-07-19 05:51:39 | Re: add function argument names to regex* functions. |