Re: PG_TEST_EXTRA and meson

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: PG_TEST_EXTRA and meson
Date: 2024-09-02 15:02:27
Message-ID: CAN55FZ2tuKSL5dMg805cvNLQBPe73fzDMP0+V5pKD49+71_LiA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, 30 Aug 2024 at 21:36, Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>
> On Wed, Aug 28, 2024 at 8:21 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> > I do not exactly remember the reason but I think I copied the same
> > behavior as before, PG_TEST_EXTRA variable was checked in the
> > src/test/Makefile so I exported it there.
>
> Okay, give v3 a try then. This exports directly from Makefile.global.
> Since that gets pulled into a bunch of places, the scope is a lot
> wider than it used to be; I've disabled it for PGXS so it doesn't end
> up poisoning other extensions.

Patch looks good and it passes all the test cases in Ashutosh's test script.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nitin Motiani 2024-09-02 15:49:41 Re: long-standing data loss bug in initial sync of logical replication
Previous Message Bertrand Drouvot 2024-09-02 15:00:32 Re: Track IO times in pg_stat_io