| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Matheus Alcantara <mths(dot)dev(at)pm(dot)me>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Using read stream in autoprewarm |
| Date: | 2024-11-29 11:19:41 |
| Message-ID: | CAN55FZ1XSGvxyiKvrsJ5BjTF2fcROsWAeYjD3P58SSN6F8kURw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thank you for looking into this.
On Fri, 29 Nov 2024 at 06:55, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> > + old_blk = &(p->block_info[p->pos - 1]);
> > + cur_blk = &(p->block_info[p->pos]);
> Should we Assert(p->pos > 0 && p->pos < *something*)
I think it is worth adding:
+ Assert(p->pos > 0 && p->pos < p->max_pos);
+
+ old_blk = &(p->block_info[p->pos - 1]);
+ cur_blk = &(p->block_info[p->pos]);
v4 is attached.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Optimize-autoprewarm-with-read-streams.patch | text/x-patch | 5.9 KB |
| v4-0002-Count-free-buffers-at-the-start-of-the-autoprewar.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ryohei Takahashi (Fujitsu) | 2024-11-29 11:41:39 | RE: doc: pgevent.dll location |
| Previous Message | Pavel Stehule | 2024-11-29 11:08:40 | Re: how to get MAJORVERSION in meson |