Re: Add missing error codes to PANIC/FATAL error reports in xlog.c and relcache.c

Hi,

On Fri, 23 Feb 2024 at 15:34, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 23 Feb 2024, at 13:09, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> > Does errmsg_internal() need to be used all the time when turning elogs
> > into ereports? errmsg_internal()'s comment says that "This should be
> > used for "can't happen" cases that are probably not worth spending
> > translation effort on.". Is it enough to check if the error message
> > has a translation, and then decide the use of errmsg_internal() or
> > errmsg()?
>
> If it's an elog then it won't have a translation as none are included in the
> translation set. If the errmsg is generic enough to be translated anyways via
> another (un)related ereport call then we of course use that, but ideally not
> create new ones.

Thanks for the explanation.

All of your feedback is addressed in v2.

--
Regards,
Nazir Bilal Yavuz
Microsoft