From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | A wrong comment about search_indexed_tlist_for_var |
Date: | 2023-12-01 11:12:34 |
Message-ID: | CAMbWs4_SDsdYD7DdQw7RXc3jv3axbg+RGZ7aSi9GaqX=F8hNVw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
The comment of search_indexed_tlist_for_var says:
* In debugging builds, we cross-check the varnullingrels of the subplan
* output Var based on nrm_match.
However, this cross-check will also be performed in non-debug builds
ever since commit 867be9c07, which converts this check from Asserts to
test-and-elog. The commit message there also says:
Committed separately with the idea that eventually we'll revert
this. It might be awhile though.
I wonder if now is the time to revert it, since there have been no
related bugs reported for quite a while. Otherwise I think we may need
to revise the comment of search_indexed_tlist_for_var to clarify that
the cross-check is not limited to debugging builds.
Please note that if we intend to revert commit 867be9c07, we need to
revert 69c430626 too.
Thanks
Richard
From | Date | Subject | |
---|---|---|---|
Next Message | Drouvot, Bertrand | 2023-12-01 11:15:16 | Re: Synchronizing slots from primary to standby |
Previous Message | Hayato Kuroda (Fujitsu) | 2023-12-01 11:08:16 | RE: logical decoding and replication of sequences, take 2 |