| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Retire has_multiple_baserels() |
| Date: | 2023-10-10 08:22:02 |
| Message-ID: | CAMbWs4_8RcSbbfs1ASZLrMuL0c0EQgXWcoLTQD8swBRY_pQQiA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The function has_multiple_baserels() is used in set_subquery_pathlist()
to check and see if there are more than 1 base rel, by looping through
simple_rel_array[]. I think one simpler way to do that is to leverage
root->all_baserels by
bms_membership(root->all_baserels) == BMS_MULTIPLE
all_baserels is computed in deconstruct_jointree (v16) or in
make_one_rel (v15 and earlier), both are before we generate access paths
for subquery RTEs, and it contains all base rels (but not "other" rels).
So it should be a suitable replacement. I doubt that there would be any
measurable performance gains. So please consider it cosmetic.
I've attached a patch to do that. Any thoughts?
Thanks
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Retire-has_multiple_baserels.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sergei Glukhov | 2023-10-10 08:31:32 | Re: Problem, partition pruning for prepared statement with IS NULL clause. |
| Previous Message | Giampaolo Capelli | 2023-10-10 08:17:54 | Re: [PoC] run SQL over ciphertext |