| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Inconsistency between try_mergejoin_path and create_mergejoin_plan |
| Date: | 2024-06-24 06:29:53 |
| Message-ID: | CAMbWs4-sTWJ_7Ya7JfyZOUiRO_HKSuhCj3pdH8-KmkKkatBBkA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 19, 2024 at 10:24 PM Alexander Pyhalov
<a(dot)pyhalov(at)postgrespro(dot)ru> wrote:
> Richard Guo писал(а) 2024-06-19 16:30:
> > I think we can simply verify the validity of commutators for clauses in
> > the form "inner op outer" when selecting mergejoin/hash clauses. If a
> > clause lacks a commutator, we should consider it unusable for the given
> > pair of outer and inner rels. Please see the attached patch.
> This seems to be working for my test cases.
Thank you for confirming. Here is an updated patch with some tweaks to
the comments and commit message. I've parked this patch in the July
commitfest.
Thanks
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Check-the-validity-of-commutators-for-merge-hash-clauses.patch | application/octet-stream | 8.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-06-24 06:38:59 | Re: speed up a logical replica setup |
| Previous Message | Bharath Rupireddy | 2024-06-24 06:00:00 | Re: Introduce XID age and inactive timeout based replication slot invalidation |