From: | Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Sokolov Yura <y(dot)sokolov(at)postgrespro(dot)ru>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
Date: | 2018-08-02 15:09:19 |
Message-ID: | CAMGcDxejTAJVGemUCHE-1FMAcHVNTm5qn=60s8HLCH37NCW_gw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>> They can be, but currently they might not be. So this requires at least
>> big fat warning in docs and description on how to access user catalogs
>> from plugins correctly (ie to always use systable_* API on them). It
>> would be nice if we could check for it in Assert builds at least.
>
Ok, modified the sgml documentation for the above.
> Yea, I agree. I think we should just consider putting similar checks in
> the general scan APIs. With an unlikely() and the easy predictability of
> these checks, I think we should be fine, overhead-wise.
>
Ok, added unlikely() checks in the heap_* scan APIs.
Revised patchset attached.
Regards,
Nikhils
> Greetings,
>
> Andres Freund
--
Nikhil Sontakke http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Cleaning-up-of-flags-in-ReorderBufferTXN-structure.patch | application/octet-stream | 7.9 KB |
0002-Support-decoding-of-two-phase-transactions-at-PREPAR.patch | application/octet-stream | 40.1 KB |
0003-Gracefully-handle-concurrent-aborts-of-uncommitted-t.patch | application/octet-stream | 13.7 KB |
0004-Teach-test_decoding-plugin-to-work-with-2PC.patch | application/octet-stream | 28.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2018-08-02 15:17:01 | Re: [HACKERS] Bug in to_timestamp(). |
Previous Message | Cynthia Shang | 2018-08-02 15:07:00 | Re: Allow COPY's 'text' format to output a header |