From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0 |
Date: | 2015-05-08 18:50:48 |
Message-ID: | CAM3SWZQVLyXhDr1M5qup=0ojUQUSyVEHL42VoCLr-o48AOk6_Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-admin pgsql-hackers |
On Fri, May 8, 2015 at 11:35 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I think Peter (on IM) just found a more likely explanation than mine.
>
> index_close(idxRel, NoLock);
> heap_close(relation, NoLock);
> candidates = lappend_oid(candidates, idxForm->indexrelid);
> ...
>
> Yes. idxForm points into idxRel->rd_index.
>
> He's working on a fix for both this and removal of the still unnecessary
> indcheckxmin check.
This was my (last minute) blunder, in case it matters.
Attached patch fixes the bug, and removes the unnecessary indcheckxmin check.
--
Peter Geoghegan
Attachment | Content-Type | Size |
---|---|---|
infer_arbiter_indexes_bugs.patch | text/x-patch | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-05-08 18:59:22 | Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0 |
Previous Message | Andres Freund | 2015-05-08 18:35:04 | Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0 |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-05-08 18:51:46 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |
Previous Message | Fabrízio de Royes Mello | 2015-05-08 18:49:43 | Re: deparsing utility commands |