From: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
---|---|
To: | David Fetter <david(at)fetter(dot)org> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Verite <daniel(at)manitou-mail(dot)org>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, Vik Fearing <vik(at)postgresfriends(dot)org>, Isaac Morland <isaac(dot)morland(at)gmail(dot)com> |
Subject: | Re: popcount |
Date: | 2021-03-08 15:29:52 |
Message-ID: | CALtqXTdTzdZoUSxNC7jS0TjEHJvdx=R2tN6DyNFbnumdDaoHjw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 19, 2021 at 9:42 PM Isaac Morland <isaac(dot)morland(at)gmail(dot)com>
wrote:
> On Tue, 19 Jan 2021 at 11:38, David Fetter <david(at)fetter(dot)org> wrote:
>
>> You bring up an excellent point, which is that our builtin functions
>> could use a lot more documentation directly to hand than they now
>> have. For example, there's a lot of needless ambiguity created by
>> function comments which leave it up in the air as to which positional
>> argument does what in functions like string_to_array, which take
>> multiple arguments. I'll try to get a patch in for the next CF with a
>> fix for that, and a separate one that doesn't put it on people to use
>> \df+ to find the comments we do provide. There have been proposals for
>> including an optional space for COMMENT ON in DDL, but I suspect that
>> those won't fly unless and until they make their way into the
>> standard.
>>
>
> Since you mention \df+, I wonder if this is the time to consider removing
> the source code from \df+ (since we have \sf) and adding in the proacl
> instead?
>
> The cf bot failed to apply the patch (v4-0001-popcount.patch) because of
the wrong "-p"
I have regenerated the patch, can you please take a look.
http://cfbot.cputube.org/patch_32_2917.log
=== applying patch ./v4-0001-popcount.patch
can't find file to patch at input line 21
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
--
Ibrar Ahmed
Attachment | Content-Type | Size |
---|---|---|
v5-0001-popcount.patch | application/octet-stream | 7.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Mark Dilger | 2021-03-08 15:39:44 | Re: proposal: psql –help reflecting service or URI usage |
Previous Message | Floris Van Nee | 2021-03-08 15:25:11 | RE: non-HOT update not looking at FSM for large tuple update |