From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: fix archive module shutdown callback |
Date: | 2022-10-18 09:08:07 |
Message-ID: | CALj2ACXtpSSfP1xEdrD2vp7Q95=9Ls55bUsG3c0qRu4dc_yo5A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Oct 17, 2022 at 11:17 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Oct 17, 2022 at 02:30:52PM +0900, Kyotaro Horiguchi wrote:
>
> Removing PG_ENSURE_ERROR_CLEANUP() and relying on before_shmem_exit()
> is fine by me, that's what I imply upthread.
Hm. Here's a v2 patch that addresses review comments. In addition to
making it a before_shmem_exit() callback, this patch also does the
following things:
1) Renames call_archive_module_shutdown_callback() to be more
meaningful and generic as before_shmem_exit() callback.
2) Clarifies when the archive module shutdown callback gets called in
documentation.
3) Defines a shutdown callback that just emits a log message in
shell_archive.c and tests it.
Please review it further.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Fixes-related-to-archive-module-shutdown-callback.patch | application/x-patch | 7.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2022-10-18 09:13:53 | Re: Unnecessary lateral dependencies implied by PHVs |
Previous Message | Thomas Munro | 2022-10-18 09:06:17 | Re: [PATCH] Fix build with LLVM 15 or above |