| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | alvherre(at)alvh(dot)no-ip(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures |
| Date: | 2022-10-27 09:28:08 |
| Message-ID: | CALj2ACXik+9hbSD+tkU5dY9+SASt5AKEyB_d3-QjuwxJgWZXSQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 4, 2022 at 2:58 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Thu, Sep 29, 2022 at 7:43 PM Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> >
> > Please see the attached v1 patch.
>
> FWIW, I'm attaching Nathan's patch that introduced the new function
> pg_walfile_offset_lsn as 0002 in the v1 patch set. Here's the CF entry
> - https://commitfest.postgresql.org/40/3909/.
>
> Please consider this for further review.
I'm attaching the v2 patch set after rebasing on to the latest HEAD.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-LSN-along-with-offset-to-error-messages-repor.patch | application/x-patch | 7.7 KB |
| v2-0002-Introduce-pg_walfile_offset_lsn.patch | application/x-patch | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2022-10-27 09:31:31 | Allow single table VACUUM in transaction block |
| Previous Message | Bharath Rupireddy | 2022-10-27 09:27:47 | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |