postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: postgres_fdw - should we tighten up batch_size, fetch_size options against non-numeric values?
Date: 2021-05-17 09:58:52
Message-ID: CALj2ACVMO6wY5Pc4oe1OCgUOAtdjHuFsBDw8R5uoYR86eWFQDA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

It looks like the values such as '123.456', '789.123' '100$%$#$#',
'9,223,372,' are accepted and treated as valid integers for
postgres_fdw options batch_size and fetch_size. Whereas this is not
the case with fdw_startup_cost and fdw_tuple_cost options for which an
error is thrown. Attaching a patch to fix that.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v1-0001-Tighten-up-batch_size-fetch_size-options-against-.patch application/octet-stream 1.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-05-17 10:13:05 Re: "ERROR: deadlock detected" when replicating TRUNCATE
Previous Message Amit Langote 2021-05-17 09:52:20 Re: Forget close an open relation in ReorderBufferProcessTXN()