Re: Improve WALRead() to suck data directly from WAL buffers when possible

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improve WALRead() to suck data directly from WAL buffers when possible
Date: 2023-03-14 03:32:23
Message-ID: CALj2ACUBWfkXBU-wKnZV9muZNZZ0Zx-Ewrxx9tZzmYzGXV2JvA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Mar 12, 2023 at 11:00 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> I have some review comments to fix on
> v8-0001, so, I'll be sending out v9 patch-set soon.

Please find the attached v9 patch set for further review. I moved the
check for just-initialized WAL buffer pages before reading the page.
Up until now, it's the other way around, meaning, read the page and
then check the header if it is just-initialized, which is wrong. The
attached v9 patch set corrects it.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v9-0001-Improve-WALRead-to-suck-data-directly-from-WAL-bu.patch application/octet-stream 7.5 KB
v9-0002-Add-test-module-for-verifying-WAL-read-from-WAL-b.patch application/octet-stream 9.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2023-03-14 04:17:20 Re: Support logical replication of DDLs
Previous Message Amit Kapila 2023-03-14 03:17:03 Re: Allow logical replication to copy tables in binary format