| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Pass ParseState as down to utility functions. |
| Date: | 2024-12-10 09:02:56 |
| Message-ID: | CALdSSPhdEw6idTndg4pVW30bCkQThJWP8wzBVf0UZj5CM=QwtA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 10 Dec 2024 at 08:28, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> I would suggest to split the patch into two pieces for clarity, based
> on the fact that your v7 patch is doing more than one thing at the
> same time:
> - Introduce new tests for the new coverage (domain, CREATE TABLE OF,
> ALTER TABLE flavors) in a first patch.
> - Introduce the ParseStates in these new code paths in a second patch.
>
> By structuring things this way, it is possible to see what kind of
> difference related to the new ParseStates is introduced, based on the
> new test coverage introduced in the first patch.
>
> This makes also the whole review easier.
Ok. Sure.
> Typo here: s/exists/exist/.
Fixed, Thank you
PFA v8.
--
Best regards,
Kirill Reshke
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Add-more-regression-tests-to-various-DDL-patterns.patch | application/octet-stream | 11.8 KB |
| v8-0002-Print-out-error-position-for-number-of-DDL-comman.patch | application/octet-stream | 30.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2024-12-10 09:14:32 | Re: WARNING: missing lock on database "postgres" (OID 5) @ TID (0,4) |
| Previous Message | jian he | 2024-12-10 07:50:57 | Re: NOT ENFORCED constraint feature |