From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
---|---|
To: | emre(at)hasegeli(dot)com |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Bogus documentation for bogus geometric operators |
Date: | 2020-11-04 09:02:52 |
Message-ID: | CALT9ZEG3f4dUO9oY5e_f01_YWgtca7J2Qa4ZsG-vz6KP6q7EjQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Emre,
I've rebased and tested your proposed patch. It seems fine and sensible to
me.
I have only one thing to note: as this patch doesn't disable <^ and >^
operator for boxes the existing state of documentation seem consistent to
me:
select '((0,0),(1,1))'::box <<| '((0,1),(1,2))'::box;
----------
f
select '((0,0),(1,1))'::box <^ '((0,1),(1,2))'::box;
----------
t
So I've only reverted the changes in the documentation on geometric
functions in your patch.
PFA v3 of your patch. I'd mark it ready to commit if you agree.
Thank you!
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Deprecate-and-replace-and-operators-for-points.patch | application/octet-stream | 23.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2020-11-04 09:05:48 | Re: Move OpenSSL random under USE_OPENSSL_RANDOM |
Previous Message | Kyotaro Horiguchi | 2020-11-04 08:55:23 | Some doubious code in pgstat.c |