From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Euler Taveira <euler(at)eulerto(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Identify missing publications from publisher while create/alter subscription. |
Date: | 2021-05-04 13:20:15 |
Message-ID: | CALDaNm38drqAw4j75=EioWum=Net=iwqnfV6BUY6OGz=Scj8kQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, May 4, 2021 at 2:37 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Mon, May 3, 2021 at 7:59 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > Thanks for the comments, these comments are handle in the v7 patch
> > posted in my earlier mail.
>
> Thanks. Some comments on v7 patch:
>
> 1) How about "Add publication names from the list to a string."
> instead of
> * Append the list of publication to dest string.
>
Modified.
> 2) How about "Connect to the publisher and see if the given
> publication(s) is(are) present."
> instead of
> * Connect to the publisher and check if the publication(s) exist.
>
Modified.
> 3) Below comments are unnecessary as the functions/code following them
> will tell what the code does.
> /* Verify specified publication(s) exist in the publisher. */
> /* We are done with the remote side, close connection. */
>
> /* Verify specified publication(s) exist in the publisher. */
> PG_TRY();
> {
> check_publications(wrconn, publications, true);
> }
> PG_FINALLY();
> {
> /* We are done with the remote side, close connection. */
> walrcv_disconnect(wrconn);
> }
>
Modified.
> 4) And also the comment below that's there before check_publications
> is unnecessary, as the function name and description would say it all.
> /* Verify specified publication(s) exist in the publisher. */
>
Modified.
> 5) A typo - it is "do not exist"
> # Multiple publications does not exist.
>
Modified.
> 6) Should we use "m" specified in all the test cases something like we
> do for $stderr =~ m/threads are not supported on this platform/ or
> m/replication slot "test_slot" was not created in this database/?
> $stderr =~
> /ERROR: publication "non_existent_pub" does not exist in the
> publisher/,
Modified.
Thanks for the comments, Attached patch has the fixes for the same.
Regards,
Vignesh
Attachment | Content-Type | Size |
---|---|---|
v8-0001-Identify-missing-publications-from-publisher-whil.patch | text/x-patch | 21.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Lukasz Biegaj | 2021-05-04 13:21:07 | Re: Unresolved repliaction hang and stop problem. |
Previous Message | Tomas Vondra | 2021-05-04 12:37:22 | Re: WIP: WAL prefetch (another approach) |