Re: Logical Replication of sequences

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: Re: Logical Replication of sequences
Date: 2024-08-19 13:08:17
Message-ID: CALDaNm307qDx9gf5s+HPuOG=PH3X=J6d68_zpjeeKZfKQcCJ=w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 19 Aug 2024 at 07:47, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here are my review comments for the latest patchset
>
> v20240817-0001. No changes. No comments.
> v20240817-0002. No changes. No comments.
> v20240817-0003. See below.
> v20240817-0004. See below.
> v20240817-0005. No changes. No comments.
>
> //////
>
> v20240817-0003 and 0004.
>
> (This is a repeat of the same comment as in previous reviews, but lots
> more functions seem affected now)
>
> IIUC, the LR code tries to follow function naming conventions (e.g.
> CamelCase/snake_case for exposed/static functions respectively),
> intended to make the code more readable. But, this only works if the
> conventions are followed.
>
> Now, patches 0003 and 0004 are shuffling more and more functions
> between modules while changing them from static to non-static (or vice
> versa). So, the function name conventions are being violated many
> times. IMO these functions ought to be renamed according to their new
> modifiers to avoid the confusion caused by ignoring the name
> conventions.

I have handled these in the v20240819 version patch attached.

Regards,
Vignesh

Attachment Content-Type Size
v20240819-0001-Introduce-pg_sequence_state-function-for-e.patch text/x-patch 11.4 KB
v20240819-0004-Enhance-sequence-synchronization-during-su.patch text/x-patch 89.7 KB
v20240819-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch text/x-patch 44.4 KB
v20240819-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch text/x-patch 90.4 KB
v20240819-0005-Documentation-for-sequence-synchronization.patch text/x-patch 23.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-08-19 13:10:12 Re: Opinion poll: Sending an automated email to a thread when it gets added to the commitfest
Previous Message Joe Conway 2024-08-19 12:11:36 Re: gitmaster server problem?