Re: Added schema level support for publication.

From: vignesh C <vignesh21(at)gmail(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Subject: Re: Added schema level support for publication.
Date: 2021-08-03 15:08:28
Message-ID: CALDaNm23wd190OZep0aT=E4T1cBU=GsN2ZsiucjoiS9rd3ATNQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 3, 2021 at 12:00 PM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Monday, August 2, 2021 11:40 PM vignesh C <vignesh21(at)gmail(dot)com>wrote:
> >
> > Thanks for the comments, attached v17 patches has the fixes for the same.
>
> Thanks for your new patch.
>
> I saw the following warning when compiling. It seems we don't need this variable any more.
>
> publicationcmds.c: In function ‘AlterPublicationSchemas’:
> publicationcmds.c:592:15: warning: unused variable ‘oldlc’ [-Wunused-variable]
> ListCell *oldlc;
> ^~~~~

Thanks for reporting this, this is fixed in the v18 patch attached.

Regards,
Vignesh

Attachment Content-Type Size
v18-0001-Added-schema-level-support-for-publication.patch text/x-patch 96.1 KB
v18-0002-Tests-and-documentation-for-schema-level-support.patch text/x-patch 54.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-08-03 15:22:31 Re: Make relfile tombstone files conditional on WAL level
Previous Message Tom Lane 2021-08-03 15:01:37 CLOBBER_CACHE_ALWAYS testing (was Re: Release 13 of the PostgreSQL BuildFarm client)