From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Race condition in FetchTableStates() breaks synchronization of subscription tables |
Date: | 2024-03-13 03:48:48 |
Message-ID: | CALDaNm10R7L0Dxq+-J=Pp3AfM_yaokpbhECvJ69QiGH8-jQquw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 12 Mar 2024 at 09:34, Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
>
>
> On Tue, Mar 12, 2024 at 2:59 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>>
>>
>> Thanks, I have created the following Commitfest entry for this:
>> https://commitfest.postgresql.org/47/4816/
>>
>> Regards,
>> Vignesh
>
>
> Thanks for the patch, I have verified that the fix works well by following the steps mentioned to reproduce the problem.
> Reviewing the patch, it seems good and is well documented. Just one minor comment I had was probably to change the name of the variable table_states_valid to table_states_validity. The current name made sense when it was a bool, but now that it is a tri-state enum, it doesn't fit well.
Thanks for reviewing the patch, the attached v6 patch has the changes
for the same.
Regards,
Vignesh
Attachment | Content-Type | Size |
---|---|---|
v6-0002-Apply-worker-will-get-started-after-180-seconds-b.patch | text/x-patch | 2.2 KB |
v6-0001-Table-sync-missed-for-newly-added-tables-because-.patch | text/x-patch | 3.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2024-03-13 03:51:32 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
Previous Message | Nathan Bossart | 2024-03-13 03:07:17 | Re: pg_column_toast_chunk_id: a function to get a chunk ID of a TOASTed value |