From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Subject: | Re: Added schema level support for publication. |
Date: | 2021-10-11 06:16:58 |
Message-ID: | CALDaNm07zRp+33aSjd9TgOum-GfqRv_caJTzctN_WgoANaAEbA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Oct 7, 2021 at 12:51 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Wed, Oct 6, 2021 at 4:42 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Attached v37 patch has the changes for the same.
> >
>
> A small issue I noticed is that using "\dS" in PSQL shows UNLOGGED
> tables as belonging to a publication, if the table belongs to a schema
> that was added to the publication using ALL TABLES IN SCHEMA (yet
> doesn't show as part of an ALL TABLES publication).
> Since publication of UNLOGGED tables is silently skipped in the case
> of ALL TABLES and ALL TABLES IN SCHEMA, it shouldn't show as belonging
> to the publication, right?
>
> test=# \dRp+ pub2
> Publication pub2
> Owner | All tables | Inserts | Updates | Deletes | Truncates | Via root
> -------+------------+---------+---------+---------+-----------+----------
> gregn | t | t | t | t | t | f
> (1 row)
>
> test=# \dRp+ pub
> Publication pub
> Owner | All tables | Inserts | Updates | Deletes | Truncates | Via root
> -------+------------+---------+---------+---------+-----------+----------
> gregn | f | t | t | t | t | t
> Tables from schemas:
> "sch1"
>
> test=# \dS sch1.test2
> Unlogged table "sch1.test2"
> Column | Type | Collation | Nullable | Default
> --------+---------+-----------+----------+---------
> i | integer | | |
> Publications:
> "pub"
Thanks for reporting the issue. The attached patch has the fix for the issue.
Regards,
Vignesh
Attachment | Content-Type | Size |
---|---|---|
v38-0001-Added-schema-level-support-for-publication.patch | text/x-patch | 79.3 KB |
v38-0002-Client-side-changes-to-support-FOR-ALL-TABLES-IN.patch | text/x-patch | 21.6 KB |
v38-0003-Tests-for-FOR-ALL-TABLES-IN-SCHEMA-publication.patch | text/x-patch | 57.5 KB |
v38-0004-Documentation-for-FOR-ALL-TABLES-IN-SCHEMA-publi.patch | text/x-patch | 15.5 KB |
v38-0005-Implemented-pg_publication_objects-view.patch | text/x-patch | 6.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dilip Kumar | 2021-10-11 06:19:41 | Error "initial slot snapshot too large" in create replication slot |
Previous Message | Fujii Masao | 2021-10-11 06:07:10 | Re: Reword docs of feature "Remove temporary files after backend crash" |