| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-07-04 03:35:20 |
| Message-ID: | CALDaNm05EgstJCJ=LMUXpoTNi9QirLhj-7ZN1Mdo9xwvO6AbRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 4 Jul 2024 at 06:40, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh. Here are my comments for the latest patch v20240703-0001.
>
> ======
> doc/src/sgml/func.sgml
>
> nitpick - /lsn/LSN/ (all other doc pages I found use uppercase for this acronym)
>
> ======
> src/backend/commands/sequence.c
>
> nitpick - /lsn/LSN/
Thanks for the comments, the attached patch has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v20240704-0001-Introduce-pg_sequence_state-and-SetSequenc.patch | text/x-patch | 13.9 KB |
| v20240704-0003-Enhance-sequence-synchronization-during-su.patch | text/x-patch | 52.6 KB |
| v20240704-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch | text/x-patch | 95.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-07-04 03:44:06 | Re: Cannot find a working 64-bit integer type on Illumos |
| Previous Message | Andrei Lepikhov | 2024-07-04 03:11:02 | Re: Pluggable cumulative statistics |