From: | Dongming Liu <ldming101(at)gmail(dot)com> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: DSA failed to allocate memory |
Date: | 2022-04-06 07:10:39 |
Message-ID: | CAL1p7e8uGMfyc1f=49z-Feto5YD5F0eqwDQYpdmr_7ncfsoMoA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 28, 2022 at 3:53 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> Hi Dongming,
>
> Thanks for the report, and for working on the fix. Can you please
> create a commitfest entry (if you haven't already)? I plan to look at
> this soon, after the code freeze.
I created a commitfest entry https://commitfest.postgresql.org/38/3607/.
Thanks for your review.
Are you proposing that the test_dsa module should be added to the
> tree? If so, some trivial observations: "#ifndef
> HAVE_INT64_TIMESTAMP" isn't needed anymore (see commit b6aa17e0, which
> is in all supported branches), the year should be updated, and we use
> size_t instead of Size in new code.
>
Yes, I think test_dsa is very helpful and necessary to develop dsa related
features. I have removed the HAVE_INT64_TIMESTAMP related code.
Most of the code for test_dsa comes from your patch[1] and I add some
test cases.
In addition, I add a few OOM test cases that allocate a fixed size of
memory
until the memory overflows, run it twice and compare the amount of memory
they allocate. These cases will fail on the current master branch.
[1]
https://www.postgresql.org/message-id/CAEepm%3D3U7%2BRo7%3DECeQuAZoeFXs8iDVX56NXGCV7z3%3D%2BH%2BWd0Sw%40mail.gmail.com
--
Best Regards,
Dongming
Attachment | Content-Type | Size |
---|---|---|
0001-Re-bin-segment-when-dsa-memory-is-freed-v2.patch | application/octet-stream | 4.0 KB |
0002-port-test_dsa-v2.patch | application/octet-stream | 16.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2022-04-06 07:20:46 | Re: generic plans and "initial" pruning |
Previous Message | Etsuro Fujita | 2022-04-06 07:05:30 | Re: Defer selection of asynchronous subplans until the executor initialization stage |