From: | sirisha chamarthi <sirichamarthi22(at)gmail(dot)com> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Fix GetWALAvailability function code comments for WALAVAIL_REMOVED return value |
Date: | 2022-10-20 16:40:24 |
Message-ID: | CAKrAKeWNYVS8aatr94ohKKwA10-dWsBbK=qYZKZnFhRxpWfi7A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Oct 19, 2022 at 7:59 PM Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
wrote:
> At Wed, 19 Oct 2022 13:06:08 +0530, Bharath Rupireddy <
> bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote in
> > On Wed, Oct 19, 2022 at 12:39 PM sirisha chamarthi
> > <sirichamarthi22(at)gmail(dot)com> wrote:
> > >
> > > The current code comment says that the replication stream on a slot
> with the given targetLSN can't continue after a restart but even without a
> restart the stream cannot continue. The slot is invalidated and the
> walsender process is terminated by the checkpoint process. Attaching a
> small patch to fix the comment.
>
> In short, the proposed fix alone seems fine to me. If we want to show
> further details, I would add a bit as follows.
>
> | * * WALAVAIL_REMOVED means it has been removed. A replication stream on
> | * a slot with this LSN cannot continue. Note that the affected
> | * processes have been terminated by checkpointer, too.
>
Thanks for your comments! Attached the patch with your suggestions.
Thanks,
Sirisha
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Fix-GetWALAvailability-function-code-comments.patch | application/octet-stream | 1.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2022-10-20 17:04:48 | Re: cross-platform pg_basebackup |
Previous Message | Mikhail Gribkov | 2022-10-20 16:39:08 | Re: Nicely exiting PG_TRY and PG_CATCH |