| From: | yuzuko <yuzukohosoya(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu> |
| Subject: | Re: Autovacuum on partitioned table |
| Date: | 2020-02-26 02:32:49 |
| Message-ID: | CAKkQ509Gn8bOEZNmcudBYj=g97qG4PcNC2pbGxC4Ci_pPtQrEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thanks for reviewing the patch.
> > We can make it work correctly but I think perhaps we can skip updating
> > statistics values of partitioned tables other than n_mod_since_analyze
> > as the first step. Because if we support also n_live_tup and
> > n_dead_tup, user might get confused that other statistics values such
> > as seq_scan, seq_tup_read however are not supported.
>
> +1, that makes sense.
>
Yes, Indeed. I modified it not to update statistics other than
n_mod_since_analyze.
Attach the v5 patch. In this patch, pgstat_report_analyze() always reports 0 as
msg.m_live_tuples and m_dead_tuples when the relation is partitioned.
--
Best regards,
Yuzuko Hosoya
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| v5_autovacuum_on_partitioned_table.patch | application/octet-stream | 16.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2020-02-26 02:50:19 | truncating timestamps on arbitrary intervals |
| Previous Message | Michael Paquier | 2020-02-26 01:48:44 | Re: [PATCH] pg_upgrade: report the reason for failing to open the cluster version file |