Re: BitmapHeapScan streaming read user and prelim refactoring

From: Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BitmapHeapScan streaming read user and prelim refactoring
Date: 2025-03-13 09:46:12
Message-ID: CAKZiRmwr=M5VqGSW8_xrWyUz_ChdRtFU=8Bow+zzgbZ6av4oMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 12, 2025 at 9:02 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> Thanks for taking a look. I've pushed the patch to increase the
> default effective_io_concurrency.

Cool, anything > 1 is just better. Just quick question, so now we have:

#define DEFAULT_EFFECTIVE_IO_CONCURRENCY 16
#define DEFAULT_MAINTENANCE_IO_CONCURRENCY 10

Shouldn't maintenance be now also at the same value (16) instead of
10? Also, fc34b0d9de27 (5 years ago by Thomas) states about m_io_c:
"Use the new setting in heapam.c instead of the hard-coded formula
effective_io_concurrency + 10 introduced by commit 558a9165e08.", so
there was always assumption that m_io_c > e_io_c (?) Now it's kind of
inconsistent to see bitmap heap scans pushing more IOPs than
recovery(!)/ANALYZE/VACUUM or am I missing something? No pressure to
change, just asking what Your thoughts are.

-J.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-03-13 09:46:46 Re: PoC: Simplify recovery after dropping a table by LOGGING the restore LSN
Previous Message Bertrand Drouvot 2025-03-13 09:31:29 Re: [BUG]: the walsender does not update its IO statistics until it exits