| From: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Extract numeric filed in JSONB more effectively |
| Date: | 2023-08-07 07:32:25 |
| Message-ID: | CAKU4AWrXxxY_Qt_L0VXy-Uuv1yvvnvkOGC2VyLpHF=gpeQa1Eg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Pavel:
Thanks for the code level review!
>
> I am looking on your patch, and the message
>
> +
> + default:
> + elog(ERROR, "cast jsonb field to %d is not supported.", targetOid);
>
> is a little bit messy. This case should not be possible, because it is
> filtered by jsonb_cast_is_optimized. So the message should be changed or it
> needs a comment.
>
Yes, the double check is not necessary, that is removed in the attached v4
patch.
--
Best Regards
Andy Fan
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Optimize-extracting-a-given-data-type-from-jsonb.patch | application/octet-stream | 16.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2023-08-07 07:36:17 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Amit Kapila | 2023-08-07 07:12:33 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |