From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
Date: | 2019-03-20 11:43:26 |
Message-ID: | CAKJS1f9bfqQGESNC9QMLPs72pvTNkN595a5gAs4M1=Pj_Wb5YQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Thanks for reviewing this.
On Wed, 20 Mar 2019 at 04:31, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> I propose maybe more strongly comment fact so noError is applied only on "not found" event. In other cases, this flag is ignored and error is raised immediately there. I think so it is not good enough commented why.
> This is significant change - in previous releases, noError was used like really noError, so should be commented more.
I've made a change to the comments in LookupFuncWithArgs() to make
this more clear. I also ended up renaming noError to missing_ok.
Hopefully this backs up the comments and reduces the chances of
surprises.
> Regress tests are enough.
> The patch is possible to apply without problems and compile without warnings
Thanks. I also fixed a bug that caused an Assert failure when
performing DROP ROUTINE ambiguous_name; test added for that case too.
> The new status of this patch is: Ready for Committer
Great!
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
drop_func_if_not_exists_fix_v9.patch | application/octet-stream | 19.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-03-20 15:56:13 | Re: BUG #15703: Segfault in cancelled CALL-Statements |
Previous Message | Michael Paquier | 2019-03-20 09:17:27 | Re: BUG #15668: Server crash in transformPartitionRangeBounds |
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2019-03-20 11:47:06 | Re: Problems with plan estimates in postgres_fdw |
Previous Message | pantilimonov misha | 2019-03-20 11:25:23 | Re: [GSoC] application ideas |