| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Stephen Froehlich <s(dot)froehlich(at)cablelabs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
| Date: | 2018-01-29 10:12:43 |
| Message-ID: | CAKJS1f8=uq9aU82tVgpq=E+bx5hOt3RpSw_QvUP-AMba2ErZDA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-novice |
On 28 January 2018 at 10:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
>> I'd offer to put it back to the order of the enum, but I want to
>> minimise the invasiveness of the patch.
>
> I think the ordering of these items suffers greatly from "add new stuff
> at the end no matter what" syndrome. Feel free to design an ordering
> that makes more sense, but then please apply it consistently.
I've attached a patch which puts them in alphabetical order.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| create_table_like_statistics_v3.patch | application/octet-stream | 20.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pierre Ducroquet | 2018-01-29 10:20:38 | Re: JIT compiling with LLVM v9.0 |
| Previous Message | David Rowley | 2018-01-29 09:55:34 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Garry Chen | 2018-01-29 13:42:18 | Re: syntax error on Function return setoff |
| Previous Message | David Rowley | 2018-01-29 09:55:34 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |